-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Istio Ambient L7 telemetry #7345
base: master
Are you sure you want to change the base?
Conversation
It would be better for the Telemetry to check if the namespace is Ambient, and just prepare the query for Ambient. But, what if this is applied to just the pod?
|
Hi @josunect , I'm using Istio 1.22.0 and the test setup didn't quite work for me. I performed "install bookinfo as Ambient namespace with a Waypoint proxy: and it installed a waypoint but none of the bookinfo traffic generated L7 metrics. I think the command in the hackscript needs to include the After this I did get some waypoint telemetry, but only for the traffic involving Actually, I just had a convo on the #ambient slack channel and it seems like a mystery. I'll try again tomorrow... Were you using minikube?
Originally, I too thought we would be able to make this sort of optimization. But because of the design flexibility that you mention above, I don't think it's possible. I think it's only possible if maybe Kiali is told that the mesh is "ambient only", or something like that, and then we can assume that we don't have any sidecar telem. |
Thanks, @jshaughn I have updated the hack script for bookinfo. From the logs: With kind and following the steps in https://istio.io/latest/docs/ambient/getting-started/, I have the graph: |
@jshaughn I've done some changes in the bookinfo installation script for Ambient:
(The command should be the same, |
This looks good except for one thing that may or may not be correct. I don't know. Take a look at this screencast - when I hover over some of the edges, almost the entire graph goes into "focus" (graying out only small parts of the graph). Screencast.from.2024-05-31.10-51-08.webmThis is when Waypoint proxies are displayed. When waypoints are not displayed, the focus looks correct. |
Thanks, @jmazzitelli . Yes, I think that should be something to fix. I'll have a look. |
Describe the change
TODO:
Steps to test the PR
Install istio Ambient 1.22:
istio/install-istio-via-istioctl.sh -c kubectl -cp ambient
istio/install-bookinfo-demo.sh -c kubectl -ai false -tg -w true
Automation testing
Issue reference
Fixes #7344