Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor issue with tautological if statement in grpc client #7354

Closed
jmazzitelli opened this issue May 14, 2024 · 2 comments · Fixed by #7380
Closed

minor issue with tautological if statement in grpc client #7354

jmazzitelli opened this issue May 14, 2024 · 2 comments · Fixed by #7380
Assignees
Labels
bug Something isn't working

Comments

@jmazzitelli
Copy link
Collaborator

I noticed this "tautological" if statement.... basically, it is doing if nil == nil because err is nil at this point:

https://github.com/kiali/kiali/blob/v1.84.0/tracing/jaeger/grpc_client.go#L38

This if-statement should be removed, unless I'm not understanding something in this code.

@jmazzitelli jmazzitelli added the bug Something isn't working label May 14, 2024
@jshaughn
Copy link
Collaborator

+1, that if can be removed.

@jmazzitelli
Copy link
Collaborator Author

will wait for #7353 to get merged since this will conflict with the same code.

jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue May 22, 2024
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue May 22, 2024
jmazzitelli added a commit that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants