Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiali-server helm chart: Do not create ClusterRole if not needed #7357

Closed
capuche2412 opened this issue May 15, 2024 · 2 comments
Closed

kiali-server helm chart: Do not create ClusterRole if not needed #7357

capuche2412 opened this issue May 15, 2024 · 2 comments
Assignees

Comments

@capuche2412
Copy link

What do you want to discuss?

In the kiali-server Helm Chart, the clusterRole kiali-server.fullname is still created even if it is not used by the deployment. To stay with the KISS philosophy, I think it is better to not create it if .Values.deployment.view_only_mode is true.

What does it improve / What problem does it solve?

This avoids creating useless clusterRole. In my case, I do not want to create a clusterRole I don't use

What is the recommended proposal?

Just modify the chart to implement, a condition to not create it.

If you agree with this statement, I can write the PR.

@jmazzitelli
Copy link
Collaborator

That sounds reasonable. Submit a PR. Thanks.

@jmazzitelli
Copy link
Collaborator

PR merged. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants