Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with catalog plugin API for optional fields #1944

Open
sbrossie opened this issue Jan 10, 2024 · 1 comment
Open

Issue with catalog plugin API for optional fields #1944

sbrossie opened this issue Jan 10, 2024 · 1 comment
Assignees

Comments

@sbrossie
Copy link
Member

It looks like although some fields are optional, i.e. could be null, our code throws an NPE when plugin implementor specifies null as shown here

@beccagaspard
Copy link
Contributor

@sbrossie I noticed the following require an empty list and do not allow null:

ProductImp.Builder::withAvailable, ProductImp.Builder::withIncluded, PlanImp.Builder::withInitialPhases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants