Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precompile issues #856

Open
4 of 6 tasks
greged93 opened this issue Oct 24, 2023 · 0 comments
Open
4 of 6 tasks

Precompile issues #856

greged93 opened this issue Oct 24, 2023 · 0 comments
Labels
epic A macro-issue that tracks multiple sub-issues and tasks

Comments

@greged93
Copy link
Contributor

greged93 commented Oct 24, 2023 •
edited by ClementWalter

Precompiles miscellaneous issues in the current codebase.

Tasks
Beta Give feedback
  1. Audit current implementation and decide where to use cairo 1 precompiles #909
    ClementWalter
  3. Allow precompiles to be called in eth_call #888
    ClementWalter
  4. Link ssj to kakarot and deploy corresponding precompiles in the deploy flow #910
    ClementWalter
  6. feat: Precompile 0x08 ecPairing #364
    Context: isolated
@greged93 greged93 mentioned this issue Oct 24, 2023
Closed
@ClementWalter ClementWalter transferred this issue from kkrt-labs/ef-tests Dec 13, 2023
@ClementWalter ClementWalter changed the title bug: Precompile issues Precompile issues Jan 18, 2024
@ClementWalter ClementWalter added the epic A macro-issue that tracks multiple sub-issues and tasks label Jan 18, 2024
This was referenced Jan 18, 2024
Closed
Closed
Closed
@ClementWalter ClementWalter mentioned this issue Jan 30, 2024
Merged
7 tasks
ClementWalter added a commit that referenced this issue Jan 30, 2024
@ClementWalter
Add IPrecompiles and use returned gas and success flag (#925)
741ba44 
Time spent on this PR: 0.1

## Pull request type

Please check the type of change your PR introduces:

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

No gas usage for external precompiles

See also #856 

## What is the new behavior?

Use interface and returned gas and success.

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/925)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic A macro-issue that tracks multiple sub-issues and tasks
Projects
Kakarot's Project Management
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ClementWalter @greged93