Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit/integration test #37

Open
chinmayb opened this issue Feb 17, 2024 · 2 comments
Open

add unit/integration test #37

chinmayb opened this issue Feb 17, 2024 · 2 comments

Comments

@chinmayb
Copy link

chinmayb commented Feb 17, 2024

I got to know about the project from Nithin's tweet. So wanted to know more about the project. When going through the code base, I thought we could add some tests.

I added some tests here chinmayb#1 . Its just a couple of tests to begin with and contains a minor fix. We could add more in the upcoming commits/PRs. It brings up postgres as docker container during tests. Let me know your thoughts, I will raise the PR here if the approach seems fine, Thanks!

@knadh
Copy link
Owner

knadh commented Feb 19, 2024

Hi @chinmayb. Please do send the PR. Thanks!

@chinmayb
Copy link
Author

Great, here #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants