-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize sinkbinding env variable name #7872
Comments
I like this idea, maybe we can provide a |
what are these security considerations ? Any resource I can read ? |
I think the main concern is that env variables are embedded into the html/js/css which becomes public |
Problem
Currently, when using SinkBinding in Knative Eventing, the names of the environment variables are defaulted to:
K_SINK
: The URL of the resolved sink.K_CE_OVERRIDES
: A JSON object specifying overrides to the outbound event.However, modern frameworks like React.js and Next.js require environment variables to have specific prefixes for security considerations:
REACT_APP_*
for the framework to read the environment variable.NEXT_PUBLIC_*
for similar accessibility.Allowing users to customize the names of SinkBinding environment variables would greatly simplify application development. This enhancement would enable developers to integrate Knative Eventing seamlessly with these frameworks, adhering to their security protocols and reducing setup complexity.
Persona:
Which persona is this feature for?
Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.
Time Estimate (optional):
How many developer-days do you think this may take to resolve?
Additional context (optional)
Add any other context about the feature request here.
The text was updated successfully, but these errors were encountered: