Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption Cleanup: drop LegacyFakeDnsName in SANs #14992

Open
ReToCode opened this issue Mar 8, 2024 · 1 comment
Open

Encryption Cleanup: drop LegacyFakeDnsName in SANs #14992

ReToCode opened this issue Mar 8, 2024 · 1 comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ReToCode
Copy link
Member

ReToCode commented Mar 8, 2024 •
edited

Description

In our certificates for the system-internal-tls feature, we are still using certificates.LegacyFakeDnsName for legacy reasons and to make trust work on ingress layers that do not support trusting multiple SANs (like in contour and gateway-api).

As soon as this is resolved, we need to clean that up and remove certificates.LegacyFakeDnsName
@ReToCode ReToCode changed the title Drop LegacyFakeDnsName in SANs Encryption Cleanup: drop LegacyFakeDnsName in SANs Mar 8, 2024
@ReToCode ReToCode mentioned this issue Mar 8, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2024
@ReToCode ReToCode added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Serving Encryption
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ReToCode