Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

information toast has close button out of the box #10223

Open
exezbcz opened this issue May 5, 2024 · 5 comments
Open

information toast has close button out of the box #10223

exezbcz opened this issue May 5, 2024 · 5 comments
Labels
A-notification p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented May 5, 2024

image image

It probably can be renamed from "information" to "transaction is in block"

and then: Transaction hash: 69Z802OH(long string here) plus see the transaction id

image

@exezbcz exezbcz added UX first Improvement for UX p2 core functionality, or is affecting 60% of app A-notification labels May 5, 2024
@Jarsen136
Copy link
Contributor

image image
It probably can be renamed from "information" to "transaction is in block"

and then: Transaction hash: 69Z802OH(long string here) plus see the transaction id

As I got from the code, the transaction has not yet been sent to block when the information notification shows up. It means we could not show View Tx for it at that time.

No matter what, the issue of "information toast has close button out of the box " could be fixed.

@exezbcz
Copy link
Member Author

exezbcz commented May 5, 2024

As I got from the code, the transaction has not yet been sent to block when the information notification shows up. It means we could not show View Tx for it at that time.

then lets not even show the transaction hash, what can user do with that?

@Jarsen136
Copy link
Contributor

As I got from the code, the transaction has not yet been sent to block when the information notification shows up. It means we could not show View Tx for it at that time.

then lets not even show the transaction hash, what can user do with that?

It just informs that tx has been generated and started broadcasting to the block.
When the tx is confirmed in the block, there will be another successful notification showing the block Id.

@exezbcz
Copy link
Member Author

exezbcz commented May 5, 2024

It just informs that tx has been generated and started broadcasting to the block. When the tx is confirmed in the block, there will be another successful notification showing the block Id.

then lets skip the hash notif

related thing:

@exezbcz
Copy link
Member Author

exezbcz commented May 27, 2024

we wont show the hash notif, can we please solve the x-mark out of the box for these notifs (check all please)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-notification p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Development

No branches or pull requests

2 participants