Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Profile navigates to substrate generic address instead of chain … #10328

Merged
merged 3 commits into from
May 22, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 20, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 20, 2024 14:06
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team May 20, 2024 14:06
Copy link

netlify bot commented May 20, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 351664d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/664c522755d441000775be03
😎 Deploy Preview https://deploy-preview-10328--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 20, 2024
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would use getss58AddressByPrefix directly in the template, and not create a computed ref

not important this way or the other

@Jarsen136
Copy link
Contributor Author

not important this way or the other

I think so. Updated

Copy link

codeclimate bot commented May 21, 2024

Code Climate has analyzed commit 351664d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added this pull request to the merge queue May 22, 2024
Merged via the queue into kodadot:main with commit 711aa64 May 22, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile navigates to substrate generic address instead of chain address
4 participants