Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is SwiftLint supposed to be used for all algorithms? #940

Open
RobertoMachorro opened this issue Jul 5, 2020 · 0 comments
Open

Is SwiftLint supposed to be used for all algorithms? #940

RobertoMachorro opened this issue Jul 5, 2020 · 0 comments

Comments

@RobertoMachorro
Copy link

RobertoMachorro commented Jul 5, 2020

Brief Intro

I see the install_swiftlint.sh script and .swiftlint.yml config file in the root folder and assume that it's meant to check the algorithm implementations. But currently when swiftlint is run, it returns:

Done linting! Found 2070 violations, 81 serious in 378 files.

More Details

Is the intent for all algorithms to pass linting? If that is the case, would it be helpful to fix these issues and then to setup a GitHub Workflow / Action to test this in future Pull Requests and Master Commits?

Edit: The .swiftlint.yml is not ok with one letter variable names, which I appreciate, but typically puts those one letter variables in loops in a tough situation - and those are common in everyone's code. I suggest opting out of that rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant