Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New guidelines #944

Open
kelvinlauKL opened this issue Aug 29, 2020 · 0 comments
Open

New guidelines #944

kelvinlauKL opened this issue Aug 29, 2020 · 0 comments

Comments

@kelvinlauKL
Copy link
Member

Hey all,

As you may have noticed, we've been overly "relaxed" with our maintenance efforts for this repository in the last little while. After talking with Ray and the other maintainers, we've decided to make some changes that will help make the review process smoother.

Here are the main changes you should expect going forward:

No more interview solutions
Over the years, this repository has grown a lot, covering many of the common data structures and algorithms that you would learn in formal education. We've seen that new submissions in the last two years mostly consist of tutorials around interview-type questions.

We tried integrating these interview solutions into our repository, but it often included low-quality submissions that don't feature a compelling tutorial to back up the code. Of the times we reviewed such submissions, we noticed ourselves spending significant time to polish both the English prose and technical implementation.

For these reasons, we're no longer accepting submissions that are solutions to interview problems.

Higher bar for new submissions
Historically, maintainers took on the responsibility of making significant upgrades to the writing and technical implementations of each submission. Unfortunately, this can be a lot of work - especially for submissions that were relatively low in quality.

We rarely rejected submissions in the past - instead we took it to ourselves for improving it through a lengthy editing process. This led to a backlog of PRs, and increased stress for maintainers to look through each submission.

Going forward, we will play less of a role in the editing process. We'll still provide feedback for each submission, but the quality of the submission would be mainly responsible by the author.


These changes should mean we'll be able to better maintain this repository moving forward. Thank you for your understanding 😄

@kelvinlauKL kelvinlauKL pinned this issue Aug 29, 2020
@richard-ash richard-ash mentioned this issue Aug 29, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant