Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android app does not write highlights to PDF if app is closed #11763

Open
erat-verbum opened this issue May 6, 2024 · 1 comment
Open

Android app does not write highlights to PDF if app is closed #11763

erat-verbum opened this issue May 6, 2024 · 1 comment
Labels

Comments

@erat-verbum
Copy link

  • KOReader version: 2024.03.1
  • Device: Pixel 7

Issue

Even though I have enabled Always for Document > Save document (write highlights into PDF), when I open a PDF file in Android and highlight some text, the highlight does not get written to the PDF if I close the android app via the Android multitasking view.

This also happens if the app crashes or the device turns off due to low battery.

The only way I can get the PDF highlights to be written to a PDF file is by switching to the file browser view inside of KOReader. It seems that highlights are not being automatically written.

Steps to reproduce

  1. Open a PDF file inside of the android KOReader app
  2. Highlight some text
  3. Go to Android app overview and swipe the application to close it
  4. Open the KOReader app again and open the PDF file
  5. Notice that the highlight has not been written to the PDF file (but appears to have been saved in the .sdr directory).
crash.log (if applicable)

I don't think this is applicable, but I have uploaded a verbose version of the crash.log in any case.
crash.log

@Frenzie Frenzie added the Android label May 6, 2024
@hius07
Copy link
Member

hius07 commented May 6, 2024

It seems that highlights are not being automatically written.

You are right, they are written on closing the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants