FileManager: safe initial path #11774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
May 8, 2024
| @@ -731,7 +731,7 @@ function FileManager:reinit(path, focused_file) | |||
| UIManager:flushSettings() | |||
| self.dimen = Screen:getSize() | |||
| -- backup the root path and path items | |||
| self.root_path = path or self.file_chooser.path | |||
| self.root_path = BaseUtil.realpath(path or self.file_chooser.path) | |||
There was a problem hiding this comment.
This isn't necessary in some other places where it does something like self.(root_)path = path then?
There was a problem hiding this comment.
We also do it in
koreader/frontend/ui/widget/filechooser.lua
Lines 513 to 515 in 526a1fb
as
FileChooser:changeToPath can be called from elsewhere.
poire-z
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not like trailing slash in the path (except root).
Closes #11772.
This change is