Hot swapping dictionaries unavailable on NT devices

[Commodore64user]

• KOReader version: Sourdough
• Device: kindle 4 (Applies to all non-touch devices)

Issue

Hamburger menu in the dictionary lookup/wiki pop up box inaccessible to non-touch users.
When using the dictionary, this option allows the user to quickly hot swap dictionaries.

Steps to reproduce

Select a word to bring up dictionary, press up/down to cycle through the menu. Suffer in silence as the menu loops back without ever reaching the burger. Cry.

[Commodore64user]

forgot to say, the edit button next to 1/2 also is inaccessible.

[hius07]

As a Master of NT devices you may want to investigate the work of FocusManager in, for example, the Menu widget (our lists).

self.layout is populated with menu items:

koreader/frontend/ui/widget/menu.lua

Lines 1081 to 1082 in 12c3c19

	-- this is for focus manager
	table.insert(self.layout, {item_tmp})

then the TitleBar left and right buttons are added:

koreader/frontend/ui/widget/menu.lua

Lines 1096 to 1097 in 12c3c19

	-- merge TitleBar layout into self FocusManager layout
	function Menu:mergeTitleBarIntoLayout()

and finally self.layout goes to FocusManager who handles key pressings:

koreader/frontend/ui/widget/focusmanager.lua

Lines 46 to 53 in 12c3c19

	if Device:hasDPad() then
	local event_keys = {}
	-- these will all generate the same event, just with different arguments
	table.insert(event_keys, { "FocusUp", { { "Up" }, event = "FocusMove", args = {0, -1} } })
	table.insert(event_keys, { "FocusRight", { { "Right" }, event = "FocusMove", args = {1, 0} } })
	table.insert(event_keys, { "FocusDown", { { "Down" }, event = "FocusMove", args = {0, 1} } })
	table.insert(event_keys, { "Press", { { "Press" }, event = "Press" } })
	local FEW_KEYS_END_INDEX = #event_keys -- Few keys device: only setup up, down, right and press

and so on.

I'm afraid the touchscreen users are not much encouraged to dig into it.

[Commodore64user]

As a Master of NT

I am not the master, @comphilip is the true 'master of puppets' here. with his magnificent PRs #8712 and later #8859 and his masterpiece here #8877. I am at best a monkey with a typewriter. Maybe one day I will write Shakespeare level stuff.