Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/mk7z: fixups #11800

Merged
merged 3 commits into from May 12, 2024
Merged

tools/mk7z: fixups #11800

merged 3 commits into from May 12, 2024

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented May 11, 2024

Close #11797.


This change is Reviewable

A string like `1E2` is interpreted as `100` (`1×10²`):

```bash
▹ echo 0E036904 | awk '{ if ($1) print $1 }'
▹ echo 0E036904 | awk '{ if ($1!="") print $1 }'
0E036904
```
To support mawk (default awk on debian unstable).
@Frenzie
Copy link
Member

Frenzie commented May 11, 2024

It might be worth mentioning in the commit message that it's also a transitional package already in Ubuntu 24.04.

The version of `7z` provided by `p7zip-full` is now the same as `7zip`:

- symlinks are dereferenced by default (no support for `-l`)
- `7z -ba h` appends a trailing `/` to directories
  (not present in the output of `7z -slt l`)
@benoit-pierre
Copy link
Contributor Author

It might be worth mentioning in the commit message that it's also a transitional package already in Ubuntu 24.04.

Done.

@Frenzie Frenzie merged commit a4400b3 into koreader:master May 12, 2024
2 checks passed
@benoit-pierre benoit-pierre deleted the pr/mk7z_fixups branch May 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building APK fails because of unknown switch of 7z
2 participants