[Tracker] Migrate test classes to use BaseTester
and its functionalities.
#2752
Labels
code heatlh 💊
Improvement the package code health
Difficulty: easy
Describes the difficulty of an issue to be solved
help wanted
Extra attention is needed
Milestone
Following on from #2745
Our tests are grouped using classes for tests. In the past, we could not adopt our
BaseTester
everywhere, because it had some abstract methods which made it half annoying. With our kinda "new"BaseTester
-from testing.base import BaseTester
- we can adopt it everywhere.What needs to be done:
BaseTester
as the parent class of the test classesassert_close
to beself.assert_close
test_gradcheck
to useself.gradcheck
instead ofgradcheck
fromtorch.autograd
tensor_to_gradcheck_var
on thetest_gradcheck
- this is automatically handled by theBaseTester
classdtype
argument of thetest_gradcheck
and just run it usingtorch.float64
You can check #2745, which has done a bunch of these updates across our tests
The goal here is to reorganize our test suite. If you have any questions, you can call us and/or ask on our Slack page too
The text was updated successfully, but these errors were encountered: