Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WunschLineMatcher to kornia.feature.matching Module #2900

Open
lappemic opened this issue May 9, 2024 · 2 comments
Open

Move WunschLineMatcher to kornia.feature.matching Module #2900

lappemic opened this issue May 9, 2024 · 2 comments
Labels
enhancement 🚀 Improvement over an existing functionality help wanted Extra attention is needed

Comments

@lappemic
Copy link
Contributor

lappemic commented May 9, 2024

While working on issue #2899 i noticed the TODO about moving kornia.feature.sold2.WunschLineMatcher to kornia.feature.matching.

Should I go ahead and create a pull request for this change?
@lappemic lappemic added the help wanted Extra attention is needed label May 9, 2024
@johnnv1 johnnv1 added the enhancement 🚀 Improvement over an existing functionality label May 9, 2024
@johnnv1
Copy link
Member

johnnv1 commented May 9, 2024

I don't know about this matcher, but having another api “exposed” is always good -- cc @edgarriba @ducha-aiki

@edgarriba
Copy link
Member

sounds good to me

@lappemic lappemic mentioned this issue May 16, 2024
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🚀 Improvement over an existing functionality help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edgarriba @johnnv1 @lappemic