Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added 'Relude.List.permutations' #397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added 'Relude.List.permutations' #397

wants to merge 1 commit into from

Conversation

Covariance
Copy link

@Covariance Covariance commented Jan 14, 2022 •
edited

Resolves #385

I've done this one in the image and likeness of #319. However, this one actually changes the exposed interface, so I'm not sure whether I should change the hlint.dhall and how. The same goes for the documentation as I'm not entirely sure what to put there.

Also, as I assumed from the milestone, this would be introduced in 1.1.0.0, so I've placed the @SInCE tag accordingly.

EDIT: also, tests are not passing due to unsafe imports in the Relude.Lifted and I'm not entirely sure what to do with that.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@chshersh chshersh added new Bring something new into library (add function or type or interface) reexport Reexport something new labels Apr 14, 2022
@chshersh
Copy link
Contributor

Hi @Covariance 👋🏻

Thanks for implementing this issue! It's a nice reference point for any future discussion 👌🏻

I've added a comment to the original issue on how I'd love to see this implemented in relude:

I could do this myself but I have limited capacity at this time. Feel free to follow the proposed plan in my comment if you would like to contribute this issue to relude 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh Awaiting requested review from chshersh

@vrom911 vrom911 Awaiting requested review from vrom911 vrom911 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new Bring something new into library (add function or type or interface) reexport Reexport something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Relude.List.permutations return a NonEmpty.
2 participants
@Covariance @chshersh