Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductDialogCancel is not working ideally. #1

Open
szriru opened this issue May 11, 2023 · 0 comments
Open

ProductDialogCancel is not working ideally. #1

szriru opened this issue May 11, 2023 · 0 comments

Comments

@szriru
Copy link

szriru commented May 11, 2023

I think it should use "history.back('/')" rather than "window.location" to use soft-navigation for performance.

here:
https://github.com/krishnerkar/next-intercepting-routes-demo/blob/07f2689b2c8234a95672bd7d6bb81abd545b06c1/app/%40modal/(..)product/%5Bid%5D/page.tsx#LL60C14-L60C42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant