Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCM] Replace sleep with proper crd watch #376

Open
josecastillolema opened this issue Jan 25, 2023 · 0 comments
Open

[OCM] Replace sleep with proper crd watch #376

josecastillolema opened this issue Jan 25, 2023 · 0 comments

Comments

@josecastillolema
Copy link
Contributor

[enhancement]
The watch_managedcluster_status function (https://github.com/redhat-chaos/krkn/blob/main/kraken/kubernetes/client.py#L864-L885) should be rewritten using watch streams (i.e.: https://github.com/redhat-chaos/krkn/blob/main/kraken/kubernetes/client.py#L838-L861) instead of the sleep approach.

Reference: https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/CustomObjectsApi.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josecastillolema