Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger not surfacing the error when failed to send cloud event #3637

Open
yuzisun opened this issue Apr 26, 2024 · 0 comments
Open

logger not surfacing the error when failed to send cloud event #3637

yuzisun opened this issue Apr 26, 2024 · 0 comments
Labels

Comments

@yuzisun
Copy link
Member

yuzisun commented Apr 26, 2024

/kind bug

What steps did you take and what happened:
There is a regression for this PR that it nuked the error from sending cloud event
https://github.com/kserve/kserve/blob/master/pkg/logger/worker.go#L104

What did you expect to happen:

What's the InferenceService yaml:
[To help us debug please run kubectl get isvc $name -n $namespace -oyaml and paste the output]

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Istio Version:
  • Knative Version:
  • KServe Version:
  • Kubeflow version:
  • Cloud Environment:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
  • Minikube/Kind version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant