Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about value_pe #251

Open
Youngea opened this issue May 7, 2024 · 1 comment
Open

Question about value_pe #251

Youngea opened this issue May 7, 2024 · 1 comment

Comments

@Youngea
Copy link

Youngea commented May 7, 2024 •
edited

In the file, rope/value_pe/init.py
image

It seems the value embedding is rotated twice in line 230 and line 234.
From my understanding, only one rotation is enough.
Please let me know whether I misunderstood this.
Thanks.
@vpj
Copy link
Member

vpj commented May 20, 2024

Thanks. It's a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vpj @Youngea