Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[runOnDataset]: accept custom criteria in config factory #5403

Merged
merged 1 commit into from
May 20, 2024
Merged

fix[runOnDataset]: accept custom criteria in config factory #5403

merged 1 commit into from
May 20, 2024

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented May 15, 2024

Closes #5188

@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 11:11pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 11:11pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels May 15, 2024
@dqbd dqbd mentioned this pull request May 15, 2024
Closed
5 tasks
@dqbd dqbd requested a review from jacoblee93 May 18, 2024 00:28
@dqbd dqbd merged commit 05c4c76 into main May 20, 2024
17 checks passed
@dqbd dqbd deleted the dqbd/run-on-dataset-criteria-fix branch May 20, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 Awaiting requested review from jacoblee93

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LangSmith "Criteria()" and "LabeledCriteria()" do not accept custom criteria in TypeScript, despite examples
1 participant
@dqbd