Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] deprecations for v1.2.0 #526

Open
justheuristic opened this issue Nov 30, 2022 · 0 comments · May be fixed by #529
Open

[chore] deprecations for v1.2.0 #526

justheuristic opened this issue Nov 30, 2022 · 0 comments · May be fixed by #529
Labels
p2p Everything related to the libp2p-daemon. refactor Resolving technical debt

Comments

@justheuristic
Copy link
Member

Currently, p2pd has a few unused options (e.g. relay hop limit) that are no longer used. Typically, they were necessary in an older libp2p version but were eventually deprecated by libp2p devs.

To identify thee parameters, check for flags in main.go which state that the option is deprecated.

Why is this issue not in p2pd repo: before we can remove these options, we need to modify hivemind.p2p interface to no longer pass these options to the daemon.

@justheuristic justheuristic added refactor Resolving technical debt p2p Everything related to the libp2p-daemon. labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2p Everything related to the libp2p-daemon. refactor Resolving technical debt
Projects
None yet
1 participant