-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test conditions to repository #815
Comments
I don't understand the question actually. |
In https://github.com/libredirect/browser_extension/blob/master/src/assets/javascripts/services.js#L114 you rewrite regular URLs to libre frontends - but are there actually any tests (like unit tests or something like that?) that ensure the functionality is working correctly? |
Yeah, I have set of URLs in a markdown file. I just open the link and it extension redirects. I have specific sites to check for embeds. I am the tester. I rigorously test every frontend whether it is changed or not to ensure it is functional before releasing both in chromium (Need to check on other Chromium browsers too though in later time) and Firefox. |
Would it be possible to include this file in the repo? Or even better, add proper unit tests? Because I am working on an implementation of this extension in Kotlin for my Android app so tests would be super helpful. |
Could you please remind me tomorrow ? |
Hello, it's tomorrow now :) |
Sorry for the delay. This is mostly I use during testing. Certain things might be missing but major frontends are here. |
I think there should be test cases for this huge switch. so it can be checked if it actually works. |
Also, I think, Testing.md should be published in repository. So, if someone making any changes
|
Yeah, sure. I will add it. Just busy IRL. |
Maybe re-open this until you have time? |
Good Idea. |
Any updates @IkelAtomig? |
Will be uploaded during the next release. |
With merging #903, this issue will look very interesting |
Ah s**t, I really need to get back here. Life sucks ... |
ETA Sunday. Promise. |
Hi,
do you guys have something like unit tests where you test if your rewrites to free frontends actually work?
Kind Regards
The text was updated successfully, but these errors were encountered: