Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record causes of failed attempts for RetryingClient #5283

Closed
ikhoon opened this issue Nov 3, 2023 · 0 comments · Fixed by #5583
Closed

Record causes of failed attempts for RetryingClient #5283

ikhoon opened this issue Nov 3, 2023 · 0 comments · Fixed by #5583
Labels
new feature
Milestone
1.29.0

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Nov 3, 2023

Only the number of failure attempts is recorded, it is difficult to know why the attempts failed.

armeria/core/src/main/java/com/linecorp/armeria/internal/common/metric/RequestMetricSupport.java

Line 171 in 90969d1

metrics.failureAttempts().record(childrenSize);

It would be good if the cause was recorded as a tag of the meter.

"actual.requests.attempts{result=failure, cause=ResponseTimeoutException}=NN"
@ikhoon ikhoon added this to the 1.27.0 milestone Nov 3, 2023
@ikhoon ikhoon modified the milestones: 1.27.0, 1.28.0 Jan 16, 2024
@my4-dev my4-dev mentioned this issue Jan 24, 2024
Closed
@jrhee17 jrhee17 modified the milestones: 1.28.0, 1.29.0 Apr 8, 2024
@my4-dev my4-dev mentioned this issue Apr 8, 2024
Merged
@minwoox minwoox closed this as completed in da982d3 Jun 4, 2024
Dogacel pushed a commit to Dogacel/armeria that referenced this issue Jun 8, 2024
@my4-dev @jrhee17 @Dogacel
Record causes of failed attempts for RetryingClient (line#5583)
599210f 
Motivation:
line#5283

Modifications:
- Separating `onResponse` into `onResponseOnClient` and `onResponseOnServer` as refactoring
- Add `failureAttempts(Throwable error)` and `failureAttempts(HttpStatus httpstatus)` at `ClientRequestMetrics` and make us enable to record causes of failed attempts

Result:

- Closes line#5283
- The metrics for failed requests while retrying now include the cause of the failure.
Co-authored-by: jrhee17 <guins_j@guins.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
1.29.0
2 participants
@ikhoon @jrhee17