Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for Printing Entire Webpage to PDF using mkdocs-print-site-plugin #151

Open
Prajwalprakash3722 opened this issue Aug 23, 2023 · 7 comments

Comments

@Prajwalprakash3722
Copy link

I would like to propose the addition of a feature that allows users to print the entire webpage as a PDF. This can be achieved by integrating the mkdocs-print-site-plugin into the repository. This plugin provides an option to generate a PDF version of the documentation, which would make it easy for users to print or save the content for offline reference.

@sumeshpremraj
Copy link
Collaborator

Sounds good, would you be open to making a PR for this?

@Prajwalprakash3722
Copy link
Author

Yes I will submit a PR shortly

@Prajwalprakash3722
Copy link
Author

Prajwalprakash3722 commented Aug 28, 2023

is there any reason why we have not tried to update the mkdocs version? @sumeshpremraj, asking this because mkdocs-print-site-plugin is trying to update the mkdocs to latest version by default.

@sumeshpremraj
Copy link
Collaborator

No reason to not update.
But let's do the mkdocs upgrade in a separate PR, to keep things isolated and so that you can revert the upgrade alone in case of any issues.

@Prajwalprakash3722
Copy link
Author

Thanks for your suggestion. I agree with the idea of keeping things separate for better management. I'll follow your advice and perform the Markdown documentation (MkDocs) upgrade in a separate pull request. This way, we can handle any issues more effectively and maintain a clear history of changes.

Question: should we update mkdocs to the latest version?

@sumeshpremraj
Copy link
Collaborator

Sure, you can use the latest version. You can test it locally, verify that pages render correctly and then open a PR.

@gillytron
Copy link

Why not just use the print command (crtl+P) and save it to PDF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants