Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules/Packages with hyphenated names cannot be injected #58

Open
jwebbdev opened this issue Jul 9, 2015 · 0 comments
Open

Modules/Packages with hyphenated names cannot be injected #58

jwebbdev opened this issue Jul 9, 2015 · 0 comments

Comments

@jwebbdev
Copy link
Member

jwebbdev commented Jul 9, 2015

The meanio module creation expects the name of the module and the directory that contains the module to be the same. If a module is created with a hyphenated name you can't use it with dependency injection since it's not a valid variable name.

The dependency system used doesn't seem to support an explicit notation (like Angular's injection) such as

myPackage.register(['hyphenated-package', function(hyphenatedPackage) { 
 ...
}]);

If this is the case, as it seems to be, then the CLI probably shouldn't allow hyphenated package names with create, or some workaround should be found. If one already exists, I'd love to know it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant