Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle CLI turns brightness up to 100% #44

Open
filmgarage opened this issue Nov 11, 2021 · 3 comments
Open

Toggle CLI turns brightness up to 100% #44

filmgarage opened this issue Nov 11, 2021 · 3 comments

Comments

@filmgarage
Copy link
Contributor

If the screen is on and the command power off is sent, the screen is back to the former brightness when turned on again.

For example:

// Brightness 20%
rpi-backlight --p off //screen blank
rpi-backlight --p on // screen 20%

Toggle does not remember the former brightness:

// Brightness 20%
rpi-backlight --p toggle //screen blank
rpi-backlight --p toggle // screen 100%

Is this intentional? I would prefer the previous setting to be remembered.

@linusg
Copy link
Owner

linusg commented Nov 11, 2021

Yep, that was recently discussed here: #40

I consider it a mistake and agree with

I would prefer the previous setting to be remembered.

But apparently it slipped through in the past. A fix would be very welcome!

@p1r473
Copy link
Contributor

p1r473 commented Nov 11, 2021

Hi Linus,
My pull request includes a fix for this issue
https://github.com/p1r473/rpi-backlight/blob/main/rpi_backlight/cli.py#L128

@linusg
Copy link
Owner

linusg commented Nov 11, 2021

@p1r473 feel free to reopen it then! I generally don't do that myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants