Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncLabels option exists in documentation for vcluster 0.20.0 but is missing in helm chart #1773

Closed
antongri opened this issue May 14, 2024 · 1 comment · Fixed by #1783
Closed
Labels

Comments

@antongri
Copy link

What happened?

Based on documentation - https://www.vcluster.com/docs/vcluster/vcluster-yaml#experimental-syncSettings-syncLabels there should be experimental:syncSettings:syncLabels while it does not exist in latest chart https://github.com/loft-sh/vcluster/blob/v0.20.0-beta.5/chart/values.yaml

What did you expect to happen?

helm chart should have experimental:syncSettings:syncLabels option

How can we reproduce it (as minimally and precisely as possible)?

Check docs at https://www.vcluster.com/docs/vcluster/vcluster-yaml/?x0=2#experimental-syncSettings-syncLabels
Check helm chart values file here https://github.com/loft-sh/vcluster/blob/v0.20.0-beta.5/chart/values.yaml

Anything else we need to know?

No response

Host cluster Kubernetes version

$ kubectl version
# paste output here
kubectl version
Client Version: v1.29.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.3-eks-adc7111

Host cluster Kubernetes distribution

EKS v1.29.3

vlcuster version

$ vcluster --version
# paste output here
vcluster version 0.20.0-beta.5

Vcluster Kubernetes distribution(k3s(default)), k8s, k0s)

k3s

OS and Arch

OS: MacOS
Arch: arm64
@FabianKramm
Copy link
Member

Hey @antongri ! The option exists, it just has no default value in the values.yaml, so you can still use that! I added default values in #1783 to make that more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants