New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use FQIN in Dockerfile #9842

Merged

achrinza merged 1 commit into master from chore/fqin-dockerfile

Aug 18, 2023

Member

achrinza commented Aug 13, 2023

see: #9841

Checklist

DCO (Developer Certificate of Origin) signed in all commits
npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈


          chore: use FQIN in Dockerfile

c73ce70

see: #9841
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>

coveralls commented Aug 13, 2023

Pull Request Test Coverage Report for Build 5845710429

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.156%

Totals
Change from base Build 5835840895:	0.0%
Covered Lines:	9556
Relevant Lines:	12424

💛 - Coveralls

achrinza marked this pull request as ready for review

August 13, 2023 08:15

achrinza requested review from raymondfeng, dhmlau and nabdelgadir as code owners

August 13, 2023 08:15

dhmlau approved these changes

View reviewed changes

achrinza merged commit c5d7fb0 into master

13 checks passed

achrinza deleted the chore/fqin-dockerfile branch

August 18, 2023 11:05

achrinza linked an issue

that may be closed by this pull request

Use FQIN in Dockerfile #9841

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment