-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Mouse wheel usage for plugin cards #1679
Comments
I've tweaked the scrolling step size in the |
Using |
I like the new scrolling speed as well 👍 |
@pStyl3 @sibir-ine Are you sure the scroll speed actually changed? The commit you downloaded the snapshot build for has a bug that means there should be (and as far as I can tell, there is) no change in scrolling behaviour. |
Yes, the speed did indeed change. I've recorded two videos to show the difference (the following links will be deprecated once this issue is closed).
I've had the About LOOT window and the search window open during the recording, but they apparently didn't get captured, only LOOTs main window did. Video 1 is the reference, Video 2 shows how scrolling is happening now in smaller steps. |
Yeah, after double-checking, the speed has in fact changed for me too. Before, in v0.17.0+735ab41, one scroll would move the card list an entire page, including messages. Now, in v0.17.0+78a3935, one scroll moves 3 cards at a time. |
Huh, I tested again and I see the same thing. EDIT: Ah, it's because scrolling per pixel scrolls by a step size that's based on item height, while scrolling by item scrolls by 3 items at a time, which is why accidentally disabling scrolling by pixel (and so defaulting to by item) caused the change. |
By this, I think you mean auto-scroll (pressing and holding the middle mouse button shows an icon with some arrows, and then moving the mouse in a direction scrolls in that direction)? There doesn't seem to be any built-in support for it, and while I might be able to implement it on a case-by-case basis, I think that would just end up with some things not being scrollable like that, and the inconsistency might be worse than it just not being supported at all. |
That's correct. It would be a nice to have feature, though I can also understand your reasoning, if it's too much of a hassle to implement. |
I've just updated the |
That's much better, thanks. 👍 |
OK, I'll close this then as I've merged that change in 6957957, and I'm not going to look into auto-scroll any further than I have. |
I've noticed that there's one more difference between the old and new GUI when it comes to scrolling the plugin cards. The current Qt GUI scrolls the intended amount instantly, while with the old GUI scrolling once would take roughly about 1/4th of a second and the scrolling itself would transition smoothly from the current to the new position. Now that I've noticed this, I think that this transition effect seems to really help in following a point (plugin card) with your eyes moving up and down in the list, since this visual effect creates a real motion which the eye can follow. So while the current implementation is already much better than before, I think this would finetune scrolling even more. |
I don't think that would be easy to implement, but I'll reopen this so that suggestion isn't lost. |
For what it's worth, multiple programs I know also made their scrolling behavior smooth & a bit delayed, e.g. Discord, Word, Firefox. Now that doesn't really help here since AFAIK those apps aren't based upon Qt, but still it doesn't seem to be a rare feature. Searching |
I do have an idea of how to implement smooth scrolling (basically, intercept the scroll event, measure how far it would scroll, cancel the event and then scroll that distance in smaller steps over a period of time). As I see it the complexity is more around dealing with things like a user that keeps scrolling (you've got to add the extra scrolling distances to the smooth scroll that is currently happening) and more significantly how to tune the smooth scrolling so that it feels good. |
Would it be possible so that the plugin card list can be moved by pressing down the mouse wheel? Pressing down the mouse wheel currently doesn't have an effect in the plugin card list.
Also, I think that the normal scrolling using the mouse wheel scrolls LOOTs right pane too much up and down at once. Here's a screenshot with the general information card being at the top, notice the placement of
ccbgssse005-goldbrand.esl
:And here is one after I scrolled down once using the mouse wheel:
ccbgssse005-goldbrand.esl
is now at the top, almost out of view. Would it be possible to decrease the amount those incremental steps are moving the list?The text was updated successfully, but these errors were encountered: