Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flatpak] LOOT Crashes on Opening "Edit Groups" #1975

Open
RacerBG opened this issue May 10, 2024 · 31 comments
Open

[Flatpak] LOOT Crashes on Opening "Edit Groups" #1975

RacerBG opened this issue May 10, 2024 · 31 comments

Comments

@RacerBG
Copy link
Contributor

RacerBG commented May 10, 2024

Debug Log:

[21:20:51.477452] [info]: Running 64-bit LOOT on KDE Flatpak runtime and the x86_64 CPU architecture
[21:20:51.477520] [info]: LOOT version: 0.22.3+8578197d
[21:20:51.477543] [info]: libloot version: 0.22.3+b23e3314
[21:20:51.481244] [warning]: The file at $HOME/.var/app/io.github.loot.loot/data/Steam/config/libraryfolders.vdf could not be opened for reading
[21:20:51.623153] [warning]: Failed to find the style sheet for the "default" theme in the filesystem, attempting to load from built-in resources...
[21:20:51.797256] [info]: Initialising filesystem-related data for game: TES V: Skyrim Special Edition
[21:20:51.797405] [info]: Attempting to create a game handle for game type "The Elder Scrolls V: Skyrim Special Edition" with game path "$HOME/.local/share/games/steamapps/common/Skyrim Special Edition" and game local path "$HOME/.local/share/games/steamapps/compatdata/489830/pfx/drive_c/users/steamuser/AppData/Local/Skyrim Special Edition"

Terminal Output:

Qt: Session management error: Could not open network socket
QIODevice::read (QFile, "~/.var/app/io.github.loot.loot/config/heroic/gog_store/installed.json"): device not open
QIODevice::read (QFile, "~/.var/app/io.github.loot.loot/config/heroic/legendaryConfig/legendary/installed.json"): device not open
QIODevice::read (QFile, "~/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/installed.json"): device not open
QIODevice::read (QFile, "~/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary/installed.json"): device not open
QLayout::addChildLayout: layout QFormLayout "" already has a parent
@Ortham
Copy link
Member

Ortham commented May 10, 2024

Does it still crash if you use the latest master branch build's flatpak here?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 10, 2024

Yes.

Qt: Session management error: Could not open network socket
QIODevice::read (QFile, "~/.var/app/io.github.loot.loot/config/heroic/gog_store/installed.json"): device not open
QIODevice::read (QFile, "~/.var/app/io.github.loot.loot/config/heroic/legendaryConfig/legendary/installed.json"): device not open
QIODevice::read (QFile, "~/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/installed.json"): device not open
QIODevice::read (QFile, "~/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary/installed.json"): device not open
QLayout::addChildLayout: layout QFormLayout "" already has a parent
[22:31:47.267041] [info]: Running 64-bit LOOT on KDE Flatpak runtime and the x86_64 CPU architecture
[22:31:47.267113] [info]: LOOT version: 0.22.3+e9101c60
[22:31:47.267122] [info]: libloot version: 0.22.4+
[22:31:47.267534] [warning]: The file at $HOME/.var/app/io.github.loot.loot/data/Steam/config/libraryfolders.vdf could not be opened for reading
[22:31:47.405428] [warning]: Failed to find the style sheet for the "default" theme in the filesystem, attempting to load from built-in resources...
[22:31:47.568568] [info]: Backup of $HOME/.var/app/io.github.loot.loot/data/LOOT created in $HOME/.var/app/io.github.loot.loot/data/LOOT/backups/LOOT-backup-20240510T223147
[22:31:50.305485] [info]: Initialising filesystem-related data for game: Fallout 3
[22:31:50.305524] [info]: Attempting to create a game handle for game type "Fallout 3" with game path "$HOME/.local/share/games/steamapps/common/Fallout 3 goty" and game local path "$HOME/.local/share/games/steamapps/compatdata/22370/pfx/drive_c/users/steamuser/AppData/Local/Fallout3"
[22:31:50.334618] [warning]: No masterlist prelude present at $HOME/.var/app/io.github.loot.loot/data/LOOT/prelude/prelude.yaml
[22:31:50.334687] [warning]: No masterlist present at $HOME/.var/app/io.github.loot.loot/data/LOOT/games/Fallout3/masterlist.yaml
[22:31:50.720922] [info]: No LOOT update is available.
[22:31:54.724929] [info]: Initialising filesystem-related data for game: TES V: Skyrim Special Edition
[22:31:54.725026] [info]: Attempting to create a game handle for game type "The Elder Scrolls V: Skyrim Special Edition" with game path "$HOME/.local/share/games/steamapps/common/Skyrim Special Edition" and game local path "$HOME/.local/share/games/steamapps/compatdata/489830/pfx/drive_c/users/steamuser/AppData/Local/Skyrim Special Edition"
[22:31:54.799278] [warning]: No cached card exists for row 0, card sizes may not be calculated correctly
[22:31:54.808939] [warning]: No masterlist prelude present at $HOME/.var/app/io.github.loot.loot/data/LOOT/prelude/prelude.yaml
[22:31:54.809026] [warning]: No masterlist present at $HOME/.var/app/io.github.loot.loot/data/LOOT/games/Skyrim Special Edition/masterlist.yaml
[22:31:57.962268] [info]: Writing file revision info for $HOME/.var/app/io.github.loot.loot/data/LOOT/prelude/prelude.yaml.metadata.toml with ID e5ff40be50ba4d18d1293758ec3d683b1cbe2a5c and date 2024-05-10
[22:31:58.303786] [info]: Writing file revision info for $HOME/.var/app/io.github.loot.loot/data/LOOT/games/Skyrim Special Edition/masterlist.yaml.metadata.toml with ID cc356285538d9d22fb19c167dcad021a5f8aadd0 and date 2024-05-10
[22:31:59.381877] [warning]: No cached card exists for row 0, card sizes may not be calculated correctly
[22:31:59.397370] [warning]: No cached card exists for row 2, card sizes may not be calculated correctly
[22:31:59.403718] [warning]: No cached card exists for row 3, card sizes may not be calculated correctly
[22:31:59.408741] [warning]: No cached card exists for row 4, card sizes may not be calculated correctly
[22:31:59.413520] [warning]: No cached card exists for row 5, card sizes may not be calculated correctly

@Ortham
Copy link
Member

Ortham commented May 10, 2024

I'm not able to see a crash when running LOOT for Morrowind in a VM. Can you enable debug logging in LOOT's settings, quit and relaunch LOOT, then try to open the groups editor again and upload the log that produces?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 10, 2024

LOOTDebugLog.txt

@Ortham
Copy link
Member

Ortham commented May 10, 2024

Thanks, it seems that it's crashing during layout calculation, or maybe it's a rendering issue. Can you try again with this build?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 11, 2024

LOOTDebugLog.txt

@Ortham
Copy link
Member

Ortham commented May 11, 2024

That didn't help... Can you try this build?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 11, 2024

LOOTDebugLog.txt

@Ortham
Copy link
Member

Ortham commented May 11, 2024

Something weird is going on... Can you try this build?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 11, 2024

LOOTDebugLog.txt

@Ortham
Copy link
Member

Ortham commented May 11, 2024

It's crashing at the bit I wasn't expecting to matter... I've disabled some unnecessary config in case that was the issue, can you try this build?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 11, 2024

LOOTDebugLog.txt

@Ortham
Copy link
Member

Ortham commented May 18, 2024

@RacerBG I've published a build with some debug info through Flathub, can you install it like so:

flatpak install --user https://dl.flathub.org/build-repo/104771/io.github.loot.loot.flatpakref
flatpak install --user loot-origin io.github.loot.loot.Debug

loot-origin should be whatever is displayed as the remote when the first command runs: it might be called something different for you.

You may need to uninstall other versions of LOOT to prevent confusion.

Once installed, try running it again, and see if anything more is logged to the terminal when it crashes. If not, I think we'll have to get gdb involved.

@RacerBG
Copy link
Contributor Author

RacerBG commented May 18, 2024

LOOTDebugLog.txt

It still crashes. On the positive side though LOOT looks well integrated with KDE thanks to the update to Runtime 6.7.

There is a small styling issue though, the position of the "Plugins" and "Filters" tabs is centered right now while it should be on the left as it was before? And their horizontal size is suboptimal. The text string is not entirely visible.

@Ortham
Copy link
Member

Ortham commented May 19, 2024

It still crashes.

And there was nothing new in your terminal?

Can you try the following in a terminal?

  1. Run flatpak run --command=sh --devel io.github.loot.loot
  2. In the shell started by the previous command, run gdb /usr/bin/LOOT
  3. In gdb enter run
  4. It'll ask if you want to enable debuginfod for this session, choose n
  5. It'll start up LOOT, now replicate the crash by opening the groups editor.
  6. Back in gdb enter bt to show the backtrace
  7. Copy/paste the terminal contents since step 1 into this issue (in a code block so it doesn't get misformatted)

There is a small styling issue though, the position of the "Plugins" and "Filters" tabs is centered right now while it should be on the left as it was before? And their horizontal size is suboptimal. The text string is not entirely visible.

Yes, I only noticed this when testing the release build, I'll have to investigate what I can do about the changes.

@RacerBG
Copy link
Contributor Author

RacerBG commented May 20, 2024

And there was nothing new in your terminal?

Still the same.

Run flatpak run --command=sh --devel io.github.loot.loot
In the shell started by the previous command, run gdb /usr/bin/LOOT

I had to install SDK 6.7 in order to do that but after entering gdb /usr/bin/LOOT it says /usr/bin/LOOT: No such file or directory.

EDIT: My flatpaks are system installs just in case this information matters.

@Ortham
Copy link
Member

Ortham commented May 20, 2024

Sorry, it's /app/bin/LOOT, not /usr/bin/LOOT.

@RacerBG
Copy link
Contributor Author

RacerBG commented May 20, 2024

Starting program: /app/bin/LOOT
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff1d696c0 (LWP 16)]
[New Thread 0x7ffff15686c0 (LWP 17)]
[New Thread 0x7fffdebff6c0 (LWP 18)]
[New Thread 0x7fffde3fe6c0 (LWP 19)]
[New Thread 0x7fffddbfd6c0 (LWP 20)]
[New Thread 0x7fffdd3fc6c0 (LWP 21)]
[New Thread 0x7fffcffff6c0 (LWP 22)]
[New Thread 0x7fffcf7fe6c0 (LWP 23)]
[New Thread 0x7fffceffd6c0 (LWP 24)]
[New Thread 0x7fffce7fc6c0 (LWP 25)]
[New Thread 0x7fffcdffb6c0 (LWP 26)]
[Thread 0x7fffcdffb6c0 (LWP 26) exited]
[Thread 0x7fffce7fc6c0 (LWP 25) exited]
[Thread 0x7fffceffd6c0 (LWP 24) exited]
Qt: Session management error: Could not open network socket
QIODevice::read (QFile, "/home/georgi/.var/app/io.github.loot.loot/config/heroic/gog_store/installed.json"): device not open
QIODevice::read (QFile, "/home/georgi/.var/app/io.github.loot.loot/config/heroic/legendaryConfig/legendary/installed.json"): device not open
QIODevice::read (QFile, "/home/georgi/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/installed.json"): device not open
QIODevice::read (QFile, "/home/georgi/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary/installed.json"): device not open
QLayout::addChildLayout: layout QFormLayout "" already has a parent
[New Thread 0x7fffceffd6c0 (LWP 27)]
[New Thread 0x7fffce7fc6c0 (LWP 28)]
[New Thread 0x7fffcdffb6c0 (LWP 29)]
[New Thread 0x7fffcd1ff6c0 (LWP 30)]
[New Thread 0x7fffb3fff6c0 (LWP 31)]
[New Thread 0x7fffb37fe6c0 (LWP 32)]
[New Thread 0x7fffb2ffd6c0 (LWP 33)]
[New Thread 0x7fffb27fc6c0 (LWP 34)]
[Thread 0x7fffb27fc6c0 (LWP 34) exited]
[New Thread 0x7fffcc2966c0 (LWP 35)]
[New Thread 0x7fffb1ffb6c0 (LWP 36)]
[New Thread 0x7fffb1dfa6c0 (LWP 37)]
[New Thread 0x7fffb1bf96c0 (LWP 38)]
[New Thread 0x7fffb19f86c0 (LWP 39)]
[New Thread 0x7fffb17f76c0 (LWP 40)]
[New Thread 0x7fffb15f66c0 (LWP 41)]
[New Thread 0x7fffb13f56c0 (LWP 42)]
[New Thread 0x7fffb0ada6c0 (LWP 43)]
[New Thread 0x7fffb06d96c0 (LWP 44)]
[New Thread 0x7fff7ffff6c0 (LWP 45)]
[New Thread 0x7fff7f3fc6c0 (LWP 46)]
[New Thread 0x7fff7fbfe6c0 (LWP 47)]
[New Thread 0x7fff7f7fd6c0 (LWP 48)]
[New Thread 0x7fff7effb6c0 (LWP 49)]
[Thread 0x7fff7effb6c0 (LWP 49) exited]
[Thread 0x7fff7f7fd6c0 (LWP 48) exited]
[Thread 0x7fff7fbfe6c0 (LWP 47) exited]
[Thread 0x7fff7f3fc6c0 (LWP 46) exited]
[Thread 0x7fff7ffff6c0 (LWP 45) exited]
[Thread 0x7fffb06d96c0 (LWP 44) exited]
[Thread 0x7fffb0ada6c0 (LWP 43) exited]
[Thread 0x7fffb37fe6c0 (LWP 32) exited]
[Thread 0x7fffb2ffd6c0 (LWP 33) exited]
[New Thread 0x7fffb0ada6c0 (LWP 50)]
[New Thread 0x7fff7f3fc6c0 (LWP 51)]
[New Thread 0x7fff7ffff6c0 (LWP 52)]
[New Thread 0x7fffb37fe6c0 (LWP 54)]
[New Thread 0x7fffb27fc6c0 (LWP 55)]
[New Thread 0x7fffb2ffd6c0 (LWP 53)]
[New Thread 0x7fffb06d96c0 (LWP 56)]
[Thread 0x7fffb06d96c0 (LWP 56) exited]
[Thread 0x7fffb27fc6c0 (LWP 55) exited]
[Thread 0x7fffb37fe6c0 (LWP 54) exited]
[Thread 0x7fffb2ffd6c0 (LWP 53) exited]
[Thread 0x7fff7ffff6c0 (LWP 52) exited]
[Thread 0x7fff7f3fc6c0 (LWP 51) exited]
[Thread 0x7fffb0ada6c0 (LWP 50) exited]
[Thread 0x7fffb3fff6c0 (LWP 31) exited]

Thread 1 "LOOT" received signal SIGILL, Illegal instruction.
0x00005555559052fd in ?? ()
(gdb) bt
#0  0x00005555559052fd in ?? ()
#1  0x0000555555905dee in ?? ()
#2  0x00005555556d1d40 in ?? ()
#3  0x00005555556cac86 in ?? ()
#4  0x00005555556cb7ca in ?? ()
#5  0x00005555556c2538 in ?? ()
#6  0x00005555557139e6 in ?? ()
#7  0x000055555564daf4 in ?? ()
#8  0x00007ffff59e6ea5 in ?? () from /usr/lib/x86_64-linux-gnu/libQt6Core.so.6
#9  0x00007ffff660aa34 in QAction::triggered(bool) () from /usr/lib/x86_64-linux-gnu/libQt6Gui.so.6
#10 0x00007ffff660d9eb in QAction::activate(QAction::ActionEvent) () from /usr/lib/x86_64-linux-gnu/libQt6Gui.so.6
#11 0x00007ffff6d7c714 in ?? () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#12 0x00007ffff6d84a80 in ?? () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#13 0x00007ffff6bfd0e8 in QWidget::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#14 0x00007ffff6b9e258 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#15 0x00007ffff6ba7dca in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#16 0x00007ffff5984700 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt6Core.so.6
#17 0x00007ffff6ba65b3 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) ()
from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#18 0x00007ffff6c10d50 in ?? () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#19 0x00007ffff6c131b0 in ?? () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#20 0x00007ffff6b9e258 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt6Widgets.so.6
#21 0x00007ffff5984700 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt6Core.so.6
#22 0x00007ffff61e556f in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQt6Gui.so.6
#23 0x00007ffff624688c in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
from /usr/lib/x86_64-linux-gnu/libQt6Gui.so.6
#24 0x00007ffff20f3a76 in ?? () from /usr/lib/x86_64-linux-gnu/libQt6XcbQpa.so.6
#25 0x00007ffff5317e59 in g_main_context_dispatch () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#26 0x00007ffff53752b8 in g_main_context_iterate.isra () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#27 0x00007ffff5315513 in g_main_context_iteration () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#28 0x00007ffff5c7451f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt6Core.so.6
#29 0x00007ffff599120b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt6Core.so.6
#30 0x00007ffff598d44d in QCoreApplication::exec() () from /usr/lib/x86_64-linux-gnu/libQt6Core.so.6
--Type <RET> for more, q to quit, c to continue without paging--
#31 0x0000555555642167 in ?? ()
#32 0x00007ffff4e3b08a in __libc_start_call_main () from /usr/lib/x86_64-linux-gnu/libc.so.6
#33 0x00007ffff4e3b14b in __libc_start_main () from /usr/lib/x86_64-linux-gnu/libc.so.6
#34 0x0000555555644a55 in ?? ()

@Ortham
Copy link
Member

Ortham commented May 20, 2024

It looks like that didn't load any of LOOT's debug symbols...

@RacerBG
Copy link
Contributor Author

RacerBG commented May 20, 2024

It looks like that didn't load any of LOOT's debug symbols...

They were enabled though.

@Ortham
Copy link
Member

Ortham commented May 20, 2024

Yeah, I'm not sure what's going on.

@pStyl3
Copy link
Member

pStyl3 commented May 24, 2024

@RacerBG Do you use any groups that you've set up yourself? If yes, does the editor still crash, if you temporarily remove your userlist.yaml? Also, does the crash happens only for one specific game, or for every game that you've got installed?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 25, 2024

@RacerBG Do you use any groups that you've set up yourself? If yes, does the editor still crash, if you temporarily remove your userlist.yaml? Also, does the crash happens only for one specific game, or for every game that you've got installed?

No I do not have any self made groups, I do not even use that feature. I have reported it because I saw that it wasn't working and the crash happens for every game basically.

@pStyl3
Copy link
Member

pStyl3 commented May 25, 2024

Does the crash also occur with the Flatpak version of LOOT v0.22.3?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 25, 2024

Does the crash also occur with the Flatpak version of LOOT v0.22.3?

Yes.

@pStyl3
Copy link
Member

pStyl3 commented May 25, 2024

If you still have them, please also test v0.22.2, v0.22.1, v0.22.0 and v0.21.0 in descending order, until you find a version where the crash doesn't happen.

@RacerBG
Copy link
Contributor Author

RacerBG commented May 25, 2024

First, I would like to see a few confirmations of this bug from another users as well if possible. If I'm an isolated case, then it's quite worthless to pursue a solution. As I said - I'm not interested in this feature.

@pStyl3
Copy link
Member

pStyl3 commented May 25, 2024

That might be the case, but a crash is still a bug that shouldn't happen. Apparently it's an issue where the source of the problem isn't quite so easy to figure out. So - let's try to find out in which version the bug was introduced! If we can pinpoint that, so if we are able to say in version X-45 the groups editor works, but in X-46 it starts to crash, then Ortham can take that information to narrow the cause down. We've done similar bug hunts in the past, and that's why I suggested to try out a few older versions of LOOT.

@RacerBG
Copy link
Contributor Author

RacerBG commented May 25, 2024

That might be the case, but a crash is still a bug that shouldn't happen. Apparently it's an issue where the source of the problem isn't quite so easy to figure out. So - let's try to find out in which version the bug was introduced! If we can pinpoint that, so if we are able to say in version X-45 the groups editor works, but in X-46 it starts to crash, then Ortham can take that information to narrow the cause down. We've done similar bug hunts in the past, and that's why I suggested to try out a few older versions of LOOT.

Looks like the first Flatpak version is 0.21.0. Let's do this (for science)!

EDIT: The earliest to which I was able to downgrade is LOOT 0.22.0:

Commit: 0773c95394e6e6cd54728871a27545a4999c45b39cb55ab005fd213c150dad17
Subject: Update to v0.22.0 release (41c1112f)
Date: 2023-10-07 21:47:41 +0000

@pStyl3
Copy link
Member

pStyl3 commented May 25, 2024

EDIT: The earliest to which I was able to downgrade is LOOT 0.22.0:

Commit: 0773c95394e6e6cd54728871a27545a4999c45b39cb55ab005fd213c150dad17
Subject: Update to v0.22.0 release (41c1112f)
Date: 2023-10-07 21:47:41 +0000

And that version also crashes?

@RacerBG
Copy link
Contributor Author

RacerBG commented May 25, 2024

EDIT: The earliest to which I was able to downgrade is LOOT 0.22.0:
Commit: 0773c95394e6e6cd54728871a27545a4999c45b39cb55ab005fd213c150dad17
Subject: Update to v0.22.0 release (41c1112f)
Date: 2023-10-07 21:47:41 +0000

And that version also crashes?

In exactly the same way, here is the log file:

LOOTDebugLog.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants