Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[groups] pausing groups does show children as paused without pausing them #4696

Open
1 task done
Tealk opened this issue Apr 20, 2024 · 7 comments
Open
1 task done
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors bug Something isn't working help wanted May need your help to test or answer

Comments

@Tealk
Copy link

Tealk commented Apr 20, 2024

πŸ“‘ I have found these related issues/pull requests

πŸ›‘οΈ Security Policy

Description

If you pause the folder, the underlying elements are also displayed as paused, but notifications are still sent.

πŸ‘Ÿ Reproduction steps

Create a folder and a child element
Add a notification to the child element
Pause the folder
create an error

πŸ‘€ Expected behavior

no notification is sent because all elements are paused
image

πŸ˜“ Actual Behavior

notifications are sent
image

🐻 Uptime-Kuma Version

1.23.12

πŸ’» Operating System and Arch

Debian 12 (bookworm)

🌐 Browser

Firefox 125.0.1 (64-bit)

πŸ–₯️ Deployment Environment

  • Runtime: docker
  • Database: sqlite
  • Filesystem used to store the database on: ZFS
  • number of monitors: 42

πŸ“ Relevant log output

No response

@Tealk Tealk added the bug Something isn't working label Apr 20, 2024
@CommanderStorm

This comment was marked as outdated.

@CommanderStorm CommanderStorm added question Further information is requested cannot-reproduce area:monitor Everything related to monitors labels Apr 20, 2024
@CommanderStorm CommanderStorm changed the title Notification of the child elements when the folder is paused [groups] Notification of the child elements when the folder is paused Apr 20, 2024
@Tealk

This comment was marked as outdated.

@CommanderStorm

This comment was marked as outdated.

@Tealk

This comment was marked as outdated.

@CommanderStorm
Copy link
Collaborator

Okay, somehow my testing mechanism was a bit flawed.
I re-tried reproducing it on https://uptime.kuma.pet/ monitoring https://beeceptor.com/ was able to do so.

@CommanderStorm CommanderStorm added help wanted May need your help to test or answer and removed question Further information is requested cannot-reproduce labels Apr 21, 2024
@Tealk
Copy link
Author

Tealk commented Apr 21, 2024

if there is anything I can do, please let me know

@CommanderStorm
Copy link
Collaborator

I would love to have a contributor debug this.
I currently don't have the time to spend on that due to personal reasons (writing a bachelor thesis), but do have the time to review PRs.
Our contribution guide is found here: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

Debugging this would require stepping through the code with a debugger and see where/why

  • monitors are not getting paused or
  • are ignoring being paused

@CommanderStorm CommanderStorm changed the title [groups] Notification of the child elements when the folder is paused [groups] pausing groups does show children as paused without pausing them Apr 21, 2024
@CommanderStorm CommanderStorm added the area:dashboard The main dashboard page where monitors' status are shown label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors bug Something isn't working help wanted May need your help to test or answer
Projects
None yet
Development

No branches or pull requests

2 participants