Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: sticky scrolling cannot be disabled in the online editor #8514

Open
BaumiCoder opened this issue Apr 30, 2024 · 2 comments

Comments

@BaumiCoder
Copy link
Member

BaumiCoder commented Apr 30, 2024

Describe the bug

In the new online editor for student submission (#8130), for instructors editing repos (#8389) and tutors to assess submissions (#8437) there is a "sticky scrolling". This means that the headers of upper structure elements (e.g., methods, classes) stick on top of the editor as long as you are in this element.

This disturbs some users. One reason is that the other lines sometimes "jump" a bit up and down while the sticky lines appears / disappears. Another problem is on smaller screens, where the space consume is a problem.


Monaco seems to have options for this: IEditorStickyScrollOptions
I do not know if there is also an option to gave users access to these settings.

To Reproduce

  1. Open the online editor somewhere in Artemis
  2. Open a file with a longer class to be able to scroll down
  3. Scroll down until the class header get out of the view
  4. "Sticky scrolling" take action and cannot be removed

Expected behavior

I am able to remove the sticky scrolling. This decision should be saved (e.g. for the user or in the session).

In VSCodium for example I can use the Popup-Menu on the "sticky scrolling" to remove it or a command from the "Command Pallet" (F1)

Screenshots

sticky scrolling

Which version of Artemis are you seeing the problem on?

7.0.2

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response

@pzdr7
Copy link
Contributor

pzdr7 commented Apr 30, 2024

Interestingly, this toggle seems to be (partially) implemented in the Monaco editor. Unfortunately, it also seems broken at the moment, as can be reproduced in the Monaco playground.

2024-04-30.18-29-05.mp4

@pzdr7
Copy link
Contributor

pzdr7 commented Apr 30, 2024

I have opened the issue microsoft/monaco-editor#4488 in the Monaco editor repository. I suggest we wait until that issue is resolved before addressing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants