Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry integration #7

Open
kwando opened this issue Dec 10, 2019 · 3 comments
Open

Telemetry integration #7

kwando opened this issue Dec 10, 2019 · 3 comments

Comments

@kwando
Copy link

kwando commented Dec 10, 2019

Would be cool if this library exposed metrics with telemetry.

I can give that integration a go if you think it is a worthwhile idea :)

@lucaong
Copy link
Owner

lucaong commented Dec 11, 2019

Hi @kwando ,
this is a great idea :)

As cubdb strives to be small and without dependencies (also to be used in minimal environments like Nerves), the best would be to report to telemetry only if it's available in the project, and do nothing otherwise. That way, the telemetry dependency would be optional.

@kwando
Copy link
Author

kwando commented Dec 16, 2019

I'll try to find some time for this during the holidays. I'm not sure how to do things conditionally based on available dependencies, but that will be a little exercise to figure out :)

@lucaong
Copy link
Owner

lucaong commented Dec 16, 2019

The Code.ensure_loaded?/1 function is useful to check if a module can be loaded or not, for example to check if an optional dependency is present or not. Also, a dependency can be marked as optional: true in mix.exs. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants