Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the number of slots * the number of experts have to be the same as the length of the token? #2

Open
ZQpengyu opened this issue Nov 16, 2023 · 1 comment

Comments

@ZQpengyu
Copy link

Assuming I have a sequence of length 512, but num_slot * num_expert = 9, it should still be able to run. In this case, would there be a performance drop?

@andersonbcdefg
Copy link

Have to validate that empirically, but I would definitely expect a performance drop here. Because of softmax, my intuition is it's likely that 1 token dominates each expert, and some tokens get short shrift. This might be fine if you have like, 2x more slots, or maybe even 4x or 8x, but >50 tokens per slot I imagine would be skimping a bit and likely to hurt results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants