Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxes Are Applied When Marked As Inactive #1547

Open
dewebdesigns opened this issue Feb 10, 2024 · 0 comments
Open

Taxes Are Applied When Marked As Inactive #1547

dewebdesigns opened this issue Feb 10, 2024 · 0 comments
Labels
1.x bug Something isn't working

Comments

@dewebdesigns
Copy link
Contributor

  • Lunar version: 0.8.0
  • Laravel Version: 10.43.0
  • PHP Version: 8.3.2
  • Database Driver & Version: MariaDB 11.1.2

Expected Behaviour:

When you have multiple tax zones, in my instance, postcodes, and mark one as inactive, it should not return the inactive tax zone.

Actual Behaviour:

It returns the first tax zone that matches whether it is active or inactive, and sets the tax even if it is inactive.

There are no checks for the active column on the tax zone for any of the queries in the file: core/src/Actions/Taxes/GetTaxZone.php

Steps To Reproduce:

Create a tax class.
Create a tax zone with the tax rate to 10% and set it as inactive.
Add a product to your cart, set an address, and check the tax on the product. It will be at 10%.

This works for tax countries, tax states, and tax post codes.

The only way I can disable the taxes in my production site is to delete any matching records, which is not ideal.

@dewebdesigns dewebdesigns added bug Something isn't working unconfirmed labels Feb 10, 2024
@glennjacobs glennjacobs added the 1.x label May 20, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants