Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreKit -> SKStoreReviewController -> requestReviewInScene missing #541

Open
extrawurst opened this issue Dec 14, 2023 · 5 comments
Open
Labels
A-framework Affects the framework crates and the translator for them bug Something isn't working

Comments

@extrawurst
Copy link

see https://developer.apple.com/documentation/storekit/skstorereviewcontroller/3566727-requestreviewinscene?language=objc

as of 0.0.4 we seem to only provide deprecated requestReview and requestReviewInScene is missing

@madsmtm madsmtm added bug Something isn't working A-framework Affects the framework crates and the translator for them labels Dec 14, 2023
@madsmtm
Copy link
Owner

madsmtm commented Dec 14, 2023

Yeah, this is iOS only, and the APIs are currently generated assuming macOS

@extrawurst
Copy link
Author

oh i see. so only 100% identical Apis will work on both? like the discussion we had on the notifications?

@madsmtm
Copy link
Owner

madsmtm commented Dec 14, 2023

Yup, exactly.

@madsmtm
Copy link
Owner

madsmtm commented Dec 14, 2023

Just to be clear, in the interim you can do:

/// # Safety
///
/// Must be run on the main thread, and must be passed a `UIWindowScene`.
unsafe fn request_review_in_scene(window_scene: &NSObject) {
    unsafe { msg_send![SKStoreReviewController::class(), requestReviewInScene: window_scene] }
}

@extrawurst
Copy link
Author

in the interim you can do

that's great! thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Affects the framework crates and the translator for them bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants