Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#38682 - Fix DeployPackage type error #38683

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

#38682 - Fix DeployPackage type error #38683

wants to merge 1 commit into from

Conversation

Nuranto
Copy link
Contributor

@Nuranto Nuranto commented Apr 30, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Issue] Static content deploy - Type error #38682

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 30, 2024

Hi @Nuranto. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 30, 2024
@Nuranto
Copy link
Contributor Author

Nuranto commented Apr 30, 2024

@magento run all tests

@hostep hostep mentioned this pull request May 1, 2024
Draft
5 tasks
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label May 7, 2024
@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in Pull Requests Dashboard May 9, 2024
@engcom-Bravo engcom-Bravo self-assigned this May 10, 2024
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 10, 2024
@engcom-Bravo
Copy link
Contributor

Hi @Nuranto,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Create an empty less file in your theme
  • Launch setup:static-content:deploy --force

Before: ✖️ 

Screenshot 2024-05-10 at 12 06 34

After: ✔️  

Screenshot 2024-05-10 at 12 14 47

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard May 10, 2024
@engcom-Charlie engcom-Charlie self-assigned this May 10, 2024
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard May 10, 2024
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard May 10, 2024
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Charlie
Copy link
Contributor

The functional EE failures in recent 2 builds are having 2 known issues and 1 inconsistent failure, considering it as flaky. Hence moving this PR to Merge in Progress

Known Failures having open JIRA:

  1. StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #6331
  2. AdminReorderWithCatalogPriceRuleDiscountTest: #6523

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38683/dc5808a2836126d886e7655b264676a1/Functional/allure-report-ee/index.html
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38683/d699eb65cb68cff095dbf63af3fee8c7/Functional/allure-report-ee/index.html#categories
image

@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Bravo engcom-Bravo

@engcom-Charlie engcom-Charlie

Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: accept
Projects
Pull Requests Dashboard
  
Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Static content deploy - Type error
4 participants
@Nuranto @engcom-Bravo @engcom-Charlie @ihor-sviziev