Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coupon From Cart but not resetting applied_rule_ids on quote item table #38709

Open
1 of 5 tasks
tonywkc07 opened this issue May 9, 2024 · 11 comments
Open
1 of 5 tasks
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@tonywkc07
Copy link

Preconditions and environment

  • Magento version 2.4.5-p7
  • Anything else that would help a developer reproduce the bug

Steps to reproduce

  1. Create 2 cart price rules : No coupon and specific coupon
  2. No coupon settings:
    Screenshot 2024-05-09 at 10 38 14 AM
    Screenshot 2024-05-09 at 10 38 38 AM

3.Specific coupon settings:
Screenshot 2024-05-09 at 10 40 36 AM
Screenshot 2024-05-09 at 10 40 53 AM

4.Add items into shopping cart
5.Apply specific coupon code into shopping cart
6.Remove specific coupon code into shopping cart

Expected result

Should be reset quote_item applied_rule_ids

Actual result

Did not reset and still keep the specific coupon code rule id into quote_item applied_rule_ids column
Screenshot 2024-05-09 at 10 48 55 AM
Screenshot 2024-05-09 at 10 45 08 AM

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented May 9, 2024

Hi @tonywkc07. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented May 9, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Dash engcom-Dash added the Reported on 2.4.x Indicates original Magento version for the Issue report. label May 9, 2024
Copy link

m2-assistant bot commented May 9, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash
Copy link

Hi @tonywkc07

Thanks for reporting and collaboration.

Verified the issue on magento 2.4 dev instance but the issue is not reproducible.

The specific coupon code rule id in quote_item applied_rule_ids column is reset if the coupon code is removed from the shopping card.

Please refer the attached screen record. Let us know if we missed anything.

Screen.Recording.2024-05-09.at.3.21.27.PM.1.mov

@engcom-Dash engcom-Dash added the Issue: needs update Additional information is require, waiting for response label May 9, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board May 9, 2024
@tonywkc07
Copy link
Author

Thank you for your investigation!
For this case, i already builded new Magento 2 vanilla in my local env but still cannot reset quote_item applied_rule_ids.
My magento version 2.4.5-p7 and here is video link for your reference:
https://drive.google.com/file/d/12mDiXuEYmHObXdkjmfTqzvBIDFKssteO/view?usp=drive_link

@engcom-Dash
Copy link

Hi @tonywkc07

We have verified the issue on 2.4.7 instance too but the issue is not reproducible for us.

The specific coupon code rule id in quote_item applied_rule_ids column is reset if the coupon code is removed from the shopping card.

Please refer the screenrecording and let us know if we missed anything.

Screen.Recording.2024-05-13.at.5.04.08.PM.2.1.mov

@tonywkc07
Copy link
Author

Thank you for your help! Would you please kindly try to reproduce it on 2.4.5-p7 community version? Thanks!

@engcom-Dash
Copy link

Hi @tonywkc07

Verified the issue on 2.4.5-p7 and the issue is reproducable.

But we recommend you to install the latest magento stable version.

Screen.Recording.2024-05-14.at.1.52.01.PM.1.mov

Thanks.

@tonywkc07
Copy link
Author

Thank you so much! May I know that any quality patches for this case?

@smeatball
Copy link

Hello, just a +1 here, on version 2.4.6-p5 in staging. this is blocking an upgrade as our ERP is looking for the applied id discount but there isn't one as it was cancelled.
Thank-you @tonywkc07 for the reporting/proof efforts.

@tonywkc07
Copy link
Author

tonywkc07 commented May 21, 2024

Hi @engcom-Dash , @engcom-Bravo

May I know that any quality patches for this case?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

4 participants