Fix leaky monley-patching of pprint._safe_repr in boltons.ecoutils
#335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeldycke
added a commit
to kdeldycke/click-extra
that referenced
this pull request
Apr 8, 2023
|
All tests are passing. This PR is ready to be merged upstream. |
|
Forget about this change, it's not the root cause that fix #334. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the way
pprint._safe_repris locally patched inboltons.ecoutils.The symptoms are broken
pdbprompt from mypytest --pdbcalls sessions, as discribes in details at #334.That issue being quite subtle and convoluted, I cannot find a simple and elegant way to create a unittest for this, so I propose to merge the fix as-is.
This closes #334.