Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCD Bragg peak integration algorithms #33

Open
sf1919 opened this issue Nov 27, 2023 · 0 comments
Open

SCD Bragg peak integration algorithms #33

sf1919 opened this issue Nov 27, 2023 · 0 comments
Labels
STFC Effort will be contributed by STFC

Comments

@sf1919
Copy link

sf1919 commented Nov 27, 2023

Summary
A project to provide a suite of integration algorithms and visualisation tools that allows users to select the optimal integration method for a particular sample. At present Mantid only supplies 2 choices.

Intended outcome
Integrate some samples/use-cases which currently cannot do without a lot of manual adjustment (e.g. overlapping domains) - more efficient and better user experience

Improve accuracy of integration – this leads to better refinements and results.

There is a reputational benefit to ISIS.

Acceptance criteria

  • Quantitative benchmarking of different algorithms types (e.g. fitting vs summing) to check the different algorithms produce consistent refinements for standard samples for which the algorithms are equally suitable

  • Track usage data for MVP to show that new algorithms are starting to be used

  • Qualitative positive feedback on visualisation/mock-ups

How will it work?

Features in Scope:

  • Algorithm to fit peak profiles in 1D independently (in TOF/d-spacing) and sum intensity from fits in neighboring detectors. Ensuring 1D performs well is a prerequisite to fitting in 3D.
  • Algorithm to fit peaks in 3D (TOF & detector XY or Qx, Qy, Qz)
  • Algorithm to integrate by summation and adaptive box in detector XY and TOF/d-spacing
  • Learnt-profile to use strong nearby reflections to adjust profile parameter/integration box in these algorithms
  • Handling overlapping peaks (choice of integrate together, or flag to ignore)
  • Another summing algorithm (e.g. shoebox in TOF and detector XY)
  • Visualisation tools for each new algorithm to judge quality of integration (help adjust parameters and compare methods)
  • Visualisation tool for current 3D (Qx,Qy,Qz)-space integration algorithm (IntegratePeaksMD)
  • Quantitative validation/comparison of different methods – check refinements are consistent

Features out of scope:

  • Scaling/corrections to integrated data
@sf1919 sf1919 added the STFC Effort will be contributed by STFC label Nov 27, 2023
@sf1919 sf1919 added this to Release 6.10 in Mantid project roadmap Nov 27, 2023
@peterfpeterson peterfpeterson moved this from Release 6.10 to Release 6.9 in Mantid project roadmap Dec 19, 2023
@peterfpeterson peterfpeterson changed the title Bragg peak integration algorithms SCD Bragg peak integration algorithms Feb 20, 2024
@sf1919 sf1919 moved this from Release 6.9 to Release 6.10 in Mantid project roadmap Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STFC Effort will be contributed by STFC
Projects
Development

No branches or pull requests

1 participant