Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent error handling and propagation #64

Open
gregbugaj opened this issue May 19, 2023 · 0 comments
Open

Inconsistent error handling and propagation #64

gregbugaj opened this issue May 19, 2023 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@gregbugaj
Copy link
Collaborator

gregbugaj commented May 19, 2023

Currently Processors will log and possibly rethrow base Exception , this needs to be standardized across all processors and specific Exception needs to be thrown.

Example :

try:
    failedOp()
except Exception  as e:
      if silence_exceptions:
          self.logger.warning(
              "Failed OP ", exc_info=1
          )
      else:
          raise FrameFailedException(
              "Failed op exception"
          ) from e

@gregbugaj gregbugaj added bug Something isn't working help wanted Extra attention is needed labels May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant