Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode extension #1260

Open
aangelopoulos opened this issue Apr 28, 2024 · 3 comments
Open

VSCode extension #1260

aangelopoulos opened this issue Apr 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@aangelopoulos
Copy link

Describe the bug

If you close and quickly reopen a VSCode embedded browser tab, it will display the following error message. Only after a minute or so of having the tab closed does it allow you to reconnect to the session.

image

Environment

{
"marimo": "0.4.7",
"OS": "Linux",
"OS Version": "6.5.0-4-amd64",
"Processor": "x86_64",
"Python Version": "3.9.19",
"Binaries": {
"Browser": "--",
"Node": "v16.20.2"
},
"Requirements": {
"click": "8.1.3",
"importlib-resources": "6.0.0",
"jedi": "0.18.2",
"markdown": "3.6",
"pymdown-extensions": "10.8",
"pygments": "2.14.0",
"tomlkit": "0.12.4",
"uvicorn": "0.22.0",
"starlette": "0.27.0",
"websocket": "missing",
"typing-extensions": "4.9.0",
"black": "24.4.2"
}
}

Code to reproduce

This is a VSCode extension issue. I am using extension v0.1.13.

@aangelopoulos aangelopoulos added the bug Something isn't working label Apr 28, 2024
@mscolnick
Copy link
Contributor

How quickly are you closing/reopening? Are you using a keyboard shortcut? I am trying to repro (~3 seconds), and cannot repro myself

@aangelopoulos
Copy link
Author

I'm not using a keyboard shortcut. All I'm doing is

  1. Open visualize.py, my marimo notebook
  2. Click the lightning bolt, then "start marimo server (edit)"
  3. The embedded browser opens, and things start running.
  4. I close the embedded browser by clicking the x.
  5. I go back to the lightning bolt and click "Open in embedded browser"

I just checked again, and this causes the error on my system.

@mscolnick
Copy link
Contributor

Thanks for this info - it seems like it is not closing the previous connection for whatever reason. I will continue to investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants