Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home doesn't detect new files #1348

Open
dmadisetti opened this issue May 9, 2024 · 3 comments
Open

Home doesn't detect new files #1348

dmadisetti opened this issue May 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@dmadisetti
Copy link
Contributor

Describe the bug

I think home is a great start for a splash page- I've been using it more.
But it doesn't detect new files. It looks like it polls running_notebooks (you could sneak the info in there), but also why not websockets for pubsub

Environment

markdown experimental branch

Code to reproduce

Create a new file in the directory home is running

@dmadisetti dmadisetti added the bug Something isn't working label May 9, 2024
@mscolnick
Copy link
Contributor

I can add a refresh button above the notebooks. Searching can be expensive (depending on the directory) and websockets is probably overkill. Thoughts?

@dmadisetti
Copy link
Contributor Author

I don't think WebSockets are totally overkill if there's potential for home interaction to expand. But yea, the engineering effort for notebook status alone is not worth it.

I think a refresh button is what colab and jupyter allow for in their sidebars

@dmadisetti
Copy link
Contributor Author

Toggling "Include Markdown" works as a workaround rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants