Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo will not really undo the status/state #2144

Closed
sgon00 opened this issue May 24, 2020 · 5 comments
Closed

Undo will not really undo the status/state #2144

sgon00 opened this issue May 24, 2020 · 5 comments

Comments

@sgon00
Copy link

sgon00 commented May 24, 2020

Steps:

  • Open a docuemnt with marktext and the document is in non-edited mode (saved mode) by default.
  • Input a character, such as a. The status will become edited mode (not saved mode).
  • Press Ctrl+Z to undo the change.

Expected Behavior: The document should go back to non-edited mode. (saved mode)

Current Behavior: The document remains in edited mode (not saved mode). and I can never change the status back to saved mode with UNDO.

This is really an important issue in an editor. I will never know what the clean state of my document is unless I close the document and re-open it.

Thanks a lot.

@Ricardo-HE
Copy link

This seems like an important issue. Can I work on this issue?

@aisbergde
Copy link

@RicardoHE97

This seems like an important issue. Can I work on this issue?

maybe you can combine with #2148 when you work on this?

@Ricardo-HE
Copy link

@RicardoHE97

This seems like an important issue. Can I work on this issue?

maybe you can combine with #2148 when you work on this?

I will take a look into that issue as well, and see if I can solve both.

@brainchild0
Copy link
Contributor

As was #2148, I suggest closing this issue in favor of #2189.

@fxha
Copy link
Contributor

fxha commented Aug 28, 2020

I'm closing this as duplicate of #2189, even if it's not really a duplicate but an issue with the current engine. As we drop support for the current Muya engine and adding an improved version, we don't fix any issues for this any more. BTW, this is fixed by our new engine that is currently under active development.

@fxha fxha closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants