terminal no longer has transparency/opacity #1103
Labels
Comments
|
You will need to use a theme that just passes through the terminal background. Something like erf's minimal clear theme or my term theme should work. If there is a particular theme you like you can modify it to just not set the background. |
|
I just use the default-16 theme cause it's the same as my existing terminal
colors (gruvbox), what do I have to change in default-16?
…On Mon, 12 June 2023, 1:47 am Randy Palamar, ***@***.***> wrote:
You will need to use a theme that just passes through the terminal
background. Something like erf's minimal clear theme
<https://github.com/erf/vis-minimal-theme/blob/main/minimal-clear.lua> or
my term theme
<https://github.com/rnpnr/dotfiles/blob/master/.config/vis/themes/term.lua>
should work.
If there is a particular theme you like you can modify it to just not set
the background.
—
Reply to this email directly, view it on GitHub
<#1103 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJJMIYDE4XZM6DJ3NZC6DE3XKXSADANCNFSM6AAAAAAZCJYVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Sorry, dark-16.lua is what I'm using.
On Mon, 12 June 2023, 9:36 am Chris Garvin, ***@***.***>
wrote:
… I just use the default-16 theme cause it's the same as my existing
terminal colors (gruvbox), what do I have to change in default-16?
On Mon, 12 June 2023, 1:47 am Randy Palamar, ***@***.***>
wrote:
> You will need to use a theme that just passes through the terminal
> background. Something like erf's minimal clear theme
> <https://github.com/erf/vis-minimal-theme/blob/main/minimal-clear.lua>
> or my term theme
> <https://github.com/rnpnr/dotfiles/blob/master/.config/vis/themes/term.lua>
> should work.
>
> If there is a particular theme you like you can modify it to just not set
> the background.
>
> —
> Reply to this email directly, view it on GitHub
> <#1103 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJJMIYDE4XZM6DJ3NZC6DE3XKXSADANCNFSM6AAAAAAZCJYVGM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Thanks for your reply. I tried both the themes you included, unfortunatly they both seem to paint some background color, a blushish grey. Not sure what is happening?
…On Sun, Jun 11, 2023 at 08:47:13AM -0700, Randy Palamar wrote:
You will need to use a theme that just passes through the terminal background. Something like erf's [minimal clear theme](https://github.com/erf/vis-minimal-theme/blob/main/minimal-clear.lua) or my [term theme](https://github.com/rnpnr/dotfiles/blob/master/.config/vis/themes/term.lua) should work.
If there is a particular theme you like you can modify it to just not set the background.
--
Reply to this email directly or view it on GitHub:
#1103 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
I wish the vis came with themes that takes transparent background into account. Or a mechanism by which without modifying a themes file a transparent background can be obtained |
|
Patches are welcome! I find transparency annoying in most cases but I will set it up to test any patches. |
|
I also think that an editor such as vis should come with a theme that does not define a solid background and that respects the background defined by the terminal. This is how vis looks like by default in my xfce-terminal.
It is one of the first things that newcomers see, and it is disruptive. Before even thinking about how vis works, it directly distracts me into trying to find a "sane" theme that looks like ok with my terminal colour palette. |
rnpnr
added
the
meta:help-wanted
rnpnr
added a commit
to rnpnr/vis
that referenced
this issue
Nov 10, 2023
The old style handling had a lot edge cases where one of the colors or the attribute wouldn't get applied correctly. This commit adds a new style_set() method to the Ui which should be called instead of manually touching a cells style. This also means that the Cell struct can be made opaque since all the handling is now done inside the ui-terminal files. With this makes it is now viable to combine the light and dark 16 color themes into a single base-16 theme. This theme works very well with the Linux virtual console and will now be the default theme regardless of if the terminal supports 256 colors or not. This should address the common complaints about vis not respecting the users default terminal colors. fixes martanne#1151: Theming is sometimes partially applied or ignored see martanne#1103: terminal no longer has transparency/opacity see martanne#1040: Transparent background and setting options by default
rnpnr
added a commit
to rnpnr/vis
that referenced
this issue
Nov 10, 2023
The old style handling had a lot edge cases where one of the colours or the attribute wouldn't get applied correctly. This commit adds a new style_set() method to the Ui which should be called instead of manually touching a cell's style. This also means that the Cell struct can be made opaque since all the handling is now done inside the ui-terminal files. With this it is now viable to combine the light and dark 16 colour themes into a single base-16 theme. This theme works very well with the Linux virtual console and will now be the default theme regardless of if the terminal supports 256 colours or not. This should address the common complaints about vis not respecting the users default terminal colours. fixes martanne#1151: Theming is sometimes partially applied or ignored see martanne#1103: terminal no longer has transparency/opacity see martanne#1040: Transparent background and setting options by default
rnpnr
added a commit
to rnpnr/vis
that referenced
this issue
Dec 5, 2023
The old style handling had a lot edge cases where one of the colours or the attribute wouldn't get applied correctly. This commit adds a new style_set() method to the Ui which should be called instead of manually touching a cell's style. This also means that the Cell struct can be made opaque since all the handling is now done inside the ui-terminal files. With this it is now viable to combine the light and dark 16 colour themes into a single base-16 theme. This theme works very well with the Linux virtual console and will now be the default theme regardless of if the terminal supports 256 colours or not. This should address the common complaints about vis not respecting the users default terminal colours. fixes martanne#1151: Theming is sometimes partially applied or ignored see martanne#1103: terminal no longer has transparency/opacity see martanne#1040: Transparent background and setting options by default
rnpnr
added a commit
to rnpnr/vis
that referenced
this issue
Dec 6, 2023
The old style handling had a lot edge cases where one of the colours or the attribute wouldn't get applied correctly. This commit adds a new style_set() method to the Ui which should be called instead of manually touching a cell's style. This also means that the Cell struct can be made opaque since all the handling is now done inside the ui-terminal files. With this it is now viable to combine the light and dark 16 colour themes into a single base-16 theme. This theme works very well with the Linux virtual console and will now be the default theme regardless of if the terminal supports 256 colours or not. This should address the common complaints about vis not respecting the users default terminal colours. fixes martanne#1151: Theming is sometimes partially applied or ignored see martanne#1103: terminal no longer has transparency/opacity see martanne#1040: Transparent background and setting options by default
rnpnr
added a commit
to rnpnr/vis
that referenced
this issue
Feb 16, 2024
The old style handling had a lot edge cases where one of the colours or the attribute wouldn't get applied correctly. This commit adds a new style_set() method to the Ui which should be called instead of manually touching a cell's style. This also means that the Cell struct can be made opaque since all the handling is now done inside the ui-terminal files. With this it is now viable to combine the light and dark 16 colour themes into a single base-16 theme. This theme works very well with the Linux virtual console and will now be the default theme regardless of if the terminal supports 256 colours or not. This should address the common complaints about vis not respecting the users default terminal colours. fixes martanne#1151: Theming is sometimes partially applied or ignored see martanne#1103: terminal no longer has transparency/opacity see martanne#1040: Transparent background and setting options by default
|
I downloaded Gruvbox color scheme (https://github.com/samlwood/vis-gruvbox) ,which has this instruction in line 95: So I set my line 96 as follow: this makes my suckless st terminal opacity function normaly. will work. |
rnpnr
added a commit
to rnpnr/vis
that referenced
this issue
Mar 27, 2024
The old style handling had a lot edge cases where one of the colours or the attribute wouldn't get applied correctly. This commit adds a new style_set() method to the Ui which should be called instead of manually touching a cell's style. This also means that the Cell struct can be made opaque since all the handling is now done inside the ui-terminal files. With this it is now viable to combine the light and dark 16 colour themes into a single base-16 theme. This theme works very well with the Linux virtual console and will now be the default theme regardless of if the terminal supports 256 colours or not. This should address the common complaints about vis not respecting the users default terminal colours. fixes martanne#1151: Theming is sometimes partially applied or ignored see martanne#1103: terminal no longer has transparency/opacity see martanne#1040: Transparent background and setting options by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My terminal is normally transparent/opaque. When I open vis there is no longer transparency/opacity and it is a solid color background. How to keep the transparency/opacity?
The text was updated successfully, but these errors were encountered: