Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table name validation not working when extracting a column #3498

Open
ghislaineguerin opened this issue Mar 20, 2024 · 1 comment
Open

Table name validation not working when extracting a column #3498

ghislaineguerin opened this issue Mar 20, 2024 · 1 comment
Labels
ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@ghislaineguerin
Copy link
Contributor

Description

There's an issue with table name validation when creating them via "Extract Columns to Table".

When the table is created from scratch it will show a warning in the table creation form. However that warning is not showing here and it generates an error on save:
image

Once the invalid name table is saved the entire schema can't be accessed:
image

Expected behavior

Mathesar should prevent errors in table creation by warning about invalid characters.

To Reproduce

Go to Mathesar:

  • Attempt to create a new table by extracting a column.
  • Use an invalid character in the name.
@ghislaineguerin ghislaineguerin added type: bug Something isn't working needs: triage This issue has not yet been reviewed by a maintainer and removed needs: triage This issue has not yet been reviewed by a maintainer labels Mar 20, 2024
@ghislaineguerin ghislaineguerin added this to the Backlog milestone Mar 20, 2024
@seancolsen seancolsen added work: backend Related to Python, Django, and simple SQL ready Ready for implementation labels Mar 20, 2024
@kgodey kgodey modified the milestones: Backlog, v0.1.7 Mar 20, 2024
@kgodey kgodey modified the milestones: v0.1.7, Beta Apr 3, 2024
@kgodey
Copy link
Contributor

kgodey commented Apr 3, 2024

This should be handled by the backend refactor, we'll double check before the beta is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Projects
None yet
Development

No branches or pull requests

3 participants